Allow override of metrics URL in client for security#41
Open
snarlysodboxer wants to merge 5 commits intoprometheus-community:masterfrom
Open
Allow override of metrics URL in client for security#41snarlysodboxer wants to merge 5 commits intoprometheus-community:masterfrom
snarlysodboxer wants to merge 5 commits intoprometheus-community:masterfrom
Conversation
Contributor
Author
Contributor
|
Maybe better than a single override would be to have a allow filter list like |
Contributor
|
A whitelist like that makes more sense. |
|
@SuperQ if you add filter and allow multiple urls then how will you add this in request URL as that take only url , can you provide some example the the scrape filter which you gave in comment |
|
I feel this risk is mitigated by the check in this file: https://github.com/prometheus-community/PushProx/blob/master/cmd/client/main.go#L131 It blocks the client from making requests to any host on the network |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some use cases require being able to protect against a bad actor on the proxy side. E.G. someone with access to the proxy could send valid yet malicious requests through the client, defeating the purpose of the network barrier.
For example, even with RBAC setup properly, running a Kubernetes Pod with a sidecar client container would allow access to the other services in the pod by a compromised prometheus environment. I think many people's security requirements won't allow that.
This patch adds a backwards compatible
--override-urloption to the client.